Skip to content

[GTK] Do not render background if backgroundImage is set #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

[GTK] Do not render background if backgroundImage is set #2296

merged 1 commit into from
Jul 9, 2025

Conversation

@akurtakov
Copy link
Member

@akurtakov akurtakov commented Jul 9, 2025

Fixes #2290

@akurtakov
Copy link
Member Author

akurtakov commented Jul 9, 2025

@N1k145 Would you please verify this PR?

@akurtakov akurtakov self-assigned this Jul 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Test Results

   539 files   -  6     539 suites   - 6   28m 1s ⏱️ - 2m 8s
 4 369 tests  - 37   4 353 ✅  - 35   15 💤  - 3  1 ❌ +1 
16 708 runs   - 37  16 568 ✅  - 35  139 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 16c2271. ± Comparison against base commit ee60a45.

This pull request removes 37 tests. 
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testFileTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testHtmlTransfer
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromCopiedImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageData
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testImageTransfer_fromImageDataFromImage
AllWin32Tests org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testRtfTransfer
…

N1k145
N1k145 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@N1k145 N1k145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine

@akurtakov
Copy link
Member Author

akurtakov commented Jul 9, 2025

Failing test on Windows is unrelated to change in GTK only . Merge despite failing unstable test.
Thank you guys for being proactive and for helping make SWT more predictable!

@akurtakov akurtakov merged commit 9bf5a53 into eclipse-platform:master Jul 9, 2025
15 of 17 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work Jul 9, 2025
@N1k145
Copy link
Contributor

N1k145 commented Jul 9, 2025

@akurtakov thank you very much for looking into the problem and fixing the actuall implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@N1k145 N1k145 N1k145 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akurtakov akurtakov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GTK] Background images behavior differs from Windows and Mac

2 participants

@akurtakov @N1k145